Skip to content

Conversation

@tannewt
Copy link
Member

@tannewt tannewt commented Jun 17, 2024

The previous implementation would always start BLE and rely on advertising logic to make the workflow not available when on USB.

This change removes the "always enable" call in favor of a default value that is on if 1) we determine we should be discoverable or 2) we're already bonded over BLE.

The previous implementation would always start BLE and rely on
advertising logic to make the workflow not available when on USB.

This change removes the "always enable" call in favor of a default
value that is on if 1) we determine we should be discoverable or 2)
we're already bonded over BLE.
@tannewt tannewt added this to the 9.1.0 milestone Jun 17, 2024
@tannewt tannewt requested a review from dhalbert June 17, 2024 22:43
@tannewt
Copy link
Member Author

tannewt commented Jun 17, 2024

@bill88t This should improve the RAM impact of BLE workflow. It won't match 9.0.x though because of the BLE related code in IRAM.

@bill88t
Copy link

bill88t commented Jun 18, 2024

I have good news and bad news.

Good news first, from a quick test, this seems to bring back the ram usage back to normal.

It won't match 9.0.x though because of the BLE related code in IRAM.

I entered an optimization frenzy and now I'm at a net-negative ram usage.

Bad news, brings back #9291.. somewhat.

It no longer produces a crash.
The IO clock or whatever it's called is just slowing down instead of the system clock.
This means, the neopixel goes white (wrong frequency), but the system keeps on running.
The display curiously keeps on going fine (data updating).

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants