SSLSocket: Add stream protocol #9318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including select. This assumes that the SSL layer is readable/writable exactly when the underlying socket is readable/writable.
These protocol operations should not raise exceptions, but sometimes they do. Catch the exception and extract the errno value if available. At the same time, harmonize the argument types for the underlying C routines
this makes SSL sockets (which return readable when not yet actually readable) work better.
Author
|
This plays mp3s off https now, about as well as non-https |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including select. This assumes that the SSL layer is readable/writable exactly when the underlying socket is readable/writable.
Not tested. Will test monday.
Closes #9310