bleio: add central and scanner functionality, cleanup bleio API, some code restructure #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… now 2. Add scan response capability to advertising.
…n_hal routines instead. Changes made but not yet tested.
…e Characteristic Service
tannewt
requested changes
Jul 16, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
This is super exciting! I like the simplifications you've done and the move to common hal. A number of small questions I have for now. I'm excited for the world where a scan reveals all of the circuitpython powered devices I have going around me.
tannewt
approved these changes
Jul 18, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for your hard work on this.
This was referenced Jul 31, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service,Characteristic, andCharacteristicBuffer. Add new native classesCentralandScanner.Devicecode (was combined central and peripheral).AddressType. Now it's just an integer.Addresschanged correspondingly.AdvertisementData.BLE Advertisement data is now constructed in Python, inadafruit_ble.advertising.Broadcasterremoved as a separate class for beacons to avoid a lot of duplicated code. Now handled byPeripheral.bleioobject struct fields directly inshared-bindings/. Usecommon-haloperations instead.bleioobject structs out ofshared-moduleintoports/nrf/common-hal, as they were not necessarily port-independent.list_clear()inpy/objlist.cto publicmp_obj_list_clear(), because I had a use for it elsewhere.shared-module/displayio/TileGrid.cto fix gcc warning.This new version of
bleiorequires an updated version ofAdafruit_CircuitPython_BLE(adafruit_ble) library. Changes are in adafruit/Adafruit_CircuitPython_BLE#15.