-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added new board: M5Stack DinMeter (esp32s3) #10650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
As a side note: I didn't know whether a new board is considered as something that should be targeted for the current release-branch (10.0.0 as of just yesterday) or onto the main branch. Maybe this could be added as an additional guidance to https://learn.adafruit.com/how-to-add-a-new-board-to-circuitpython/submit-a-pull-request |
|
OK, the duplicate USB VID/PID check fails - what would the appropriate PID for this board be? |
tannewt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the board def! You can request a PID here: https://github.com/espressif/usb-pids
I've added an alert to that page about branches and a note on the getting setup page. Right now |
|
Co-authored-by: Scott Shawcroft <scott@tannewt.org>
tannewt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I've added a new board: M5Stack DinMeter
The compiled firmware was tested in the context of an ongoing project of mine and appears fully functional.
Explicitly tested hardware-features that work:
I didn't test WIFI, Grove I2C and power-management - but as those aren't board specific features, I expect for them to work just as well.