Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version determination for 10.x #10216

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 1, 2025

The old glob assumed one digit before the ".". Now pick anything that doesn't start with "v" and is on the main branch. These are always merge commits. Code merged in is on the second parent.

The old glob assumed one digit before the ".". Now pick anything
that doesn't start with "v" and is on the main branch. These are
always merge commits. Code merged in is on the second parent.
@tannewt tannewt requested a review from dhalbert April 1, 2025 21:37
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I was a a little worried this might match too much, but we've been pretty careful to only make tags with version numbers.

@dhalbert dhalbert merged commit 71a023c into adafruit:main Apr 1, 2025
613 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants