Add support for on disk fonts to terminalio #10208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the terminal to use a font from the disk at /fonts/terminal.lvfontbin for languages that need more characters than we want to ship. TileGrid now support 16bit indices as well. Font files for use with it are generated by the GitHub actions here: https://github.com/adafruit/circuitpython-font-generator
dhalbert
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
This looks good. I did not test, but of course you did. The logic makes sense to me.
I see the zephyr has lvgl support, https://github.com/zephyrproject-rtos/lvgl. In the long run might we rely on that upstream code? I did not look at its functionality in detail.
Yup, I think so. We'll likely need to redo the API then though. We'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the native terminal to use fonts that are too large for RAM. They may be too large if the language has many characters or emoji are supported as well.
This PR also improves TileGrid so it can support 16 bit values when needed.