Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regularize WIZnet boards #10199

Merged
merged 3 commits into from
Apr 1, 2025
Merged

Conversation

fasteddy516
Copy link

This regularizes the 3 existing WIZnet board definitions as requested by @dhalbert in PR #10179. Firmware for all boards builds successfully, and was tested on the corresponding board using this HTTP Server + Websocket script which utilizes the new W5K_ pin aliases. Please note the following:

  1. The RP2040-based boards have #pragma once declarations in both .h files. The RP2350 board does not. I suspect this ultimately makes no difference in these cases, but I'd like to make them all the same in the 'right' way. Do I make sure #pragma once is in all of the .h files, or remove it from all?

  2. All boards now have the W5K_ pin aliases as applied to the W5500-EVB-Pico2 in PR Add WIZnet W5500-EVB-Pico2 board #10179.

  3. The pin aliases added by @jepler in commit 40cc500 have been removed, as these labels are not on the board silkscreen and were only ever defined for 1 of the 3 existing boards.

  4. The RP2040-based boards both had CIRCUITPY_HOST_USB disabled by @timchinowsky in Commit 8377a74. I assume this was done for a good reason and left it in place. I did not apply this to the RP2350 board.

  5. All boards already had DEFAULT_SPI_ and DEFAULT_UART_ defined in mpconfigboard.h. I've left these in place for now, but can remove them if necessary.

  6. Since those defaults are currently in place, I've added SPI and UART to pins.c for the RP2040-based boards. The RP2350 board already had them. Again, these can be removed if necessary.

For the default peripherals, I was reluctant to remove any of them as it could "break" existing code. (I'm also pretty confident - after spending way too much time comparing the various datasheets and pinout diagrams - that those defaults are correct, but I'm happy to defer to the general consensus)

@tannewt tannewt requested a review from dhalbert March 31, 2025 16:55
@dhalbert
Copy link
Collaborator

dhalbert commented Apr 1, 2025

Re 1: all .h should have #pragma once.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and thanks for your patience amid all the discussion.

@dhalbert dhalbert merged commit 9fd0a69 into adafruit:main Apr 1, 2025
18 checks passed
@fasteddy516 fasteddy516 deleted the regularize_wiznet_boards branch April 1, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants