Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added peripheral support for Daisy Seed stm32H750 board #10198

Merged
merged 5 commits into from
Apr 7, 2025

Conversation

snkYmkrct
Copy link

@snkYmkrct snkYmkrct commented Mar 29, 2025

  • Added the SDRAM controller and set up heap to use the 64 MB external RAM
  • Added the rest of the board pin definitions from the pinout
  • Did peripheral pins cleanup for the stm32H750 chip
  • Added SDMMC peripheral and sdioio module support
  • Added pwmio support and started work on audiopwmio

@snkYmkrct snkYmkrct marked this pull request as draft March 30, 2025 11:53
@snkYmkrct snkYmkrct changed the title WIP support for Daisy Seed stm32H750 board Added peripheral support for Daisy Seed stm32H750 board Mar 30, 2025
@snkYmkrct snkYmkrct marked this pull request as ready for review March 30, 2025 21:18
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for continuing work on this! One bigish suggestion around the settings.

- Added the SDRAM controller and set up heap to use the 64 MB external RAM
- Added the rest of the board pin definitions from the pinout
- Did peripheral pins cleanup for the stm32H750 chip
- Added SDMMC peripheral and sdioio module support
- Added pwmio support and started work on audiopwmio
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Two more minor things. Thanks!


// Use the MP_WEAK supervisor/shared/board.c versions of routines not defined here.
extern void port_add_sdram_to_heap(void);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in a new supervisor/stm.h and rename to stm_add_sdram_to_heap. The port_ prefix is meant to be cross-port apis from supervisor/port.h.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made! :)

active_audio was set to NULL, but then used in the following set_pin()
call. because of MPU, this triggered hard fault on the stm32h7.
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@tannewt tannewt merged commit ea91e38 into adafruit:main Apr 7, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants