Auto-configure display on some RP2350 boards #10028

jepler · 2025-02-04T20:39:03Z

If a board has a HSTX or DVI connector, and it has I2C pull-ups built in, it's possible to auto-configure the display.

This is implemented for 2 boards: feather rp2350 & metro rp2350. It's expected to be added to fruit jam when that board definition is added.

It can't be applied to rp2040 boards right now because a particular routine to check if a video mode is valid is not yet implemented there.

it can't be applied to general rp2040/rp2350 boards because without i2c pull-ups, attempting to instantiate the i2c bus would throw an exception. This'll land you in safe mode.

The default resolution is 320x240@16bpp but this can be set via settings.toml (as can display rotation, in case you want a portrait hdmi display)

An earlier iteration of this PR changed how board.DISPLAY worked, but this is no longer the case. Instead, there's a new supervisor.runtime.display property that persists across soft resets. If board_init sets up a display, then that display is also set up there (in addition to appearing as board.DISPLAY). Otherwise, the property can be set by boot.py or code.py. This is a partial implementation of #8675, excluding the incompatible change of resetting "non-default displays" at the end of a code run, and excluding the idea of allocating SPI & I2C buses outside the GC heap.

This should be considered an RFC. Some bits should probably be moved to common code & tidied up. If connected to a HDMI monitor, an eeprom will be on the i2c bus with address 0x50. When it's found, configure the display to 320x240x16 (default), or to user settings. Invalid user settings cause a safe mode with a misleading error: "Heap allocation when VM not running." This is because common_hal_picodvi_framebuffer_construct throws an exception for invalid parameters (width, height, and color depth), but the circuitpy VM is not running. With the default framebuffer configuration, about 256KiB is left for the CircuitPython VM. When a display is configured (whether picodvi or not), board.DISPLAY exits and can be retrieved. When there's no display (including after `release_displays()`), accessing `board.DISPLAY` raises an AttributeError. This behavior should maybe adapted everywhere, but I'm not sure how much flash size it takes.

jepler · 2025-02-04T21:32:05Z

ping @ladyada

tannewt

Thanks for working on this! I'm very excited for a CP computer.

ports/raspberrypi/boards/adafruit_feather_rp2350/board.c

ports/raspberrypi/common-hal/picodvi/__init__.c

ports/raspberrypi/boards/adafruit_feather_rp2350/board.c

tannewt · 2025-02-10T22:16:17Z

Is this ready now? Would love to add it to the metro and fruit jam too.

Let's see if this works out in terms of code space.

There's only an implementation for RP2350 right now, as it's not used/needed on RP2040.

and auto-set height and support rotation similar to how it's done on some of those dot clock display espressif boards

tannewt

Just a couple of things in addition to the build failing.

docs/environment.rst

ports/espressif/boards/m5stack_m5paper/pins.c

ports/raspberrypi/common-hal/picodvi/__init__.c

.. some boards need MODULE_ATTR_DELEGATION for other reasons than displayio.

RetiredWizard · 2025-02-12T21:14:19Z

I threw an artifact onto a pimoroni_pico_dv_base_w board using the CIRCUITPY_PICODVI_ENABLE="always" setting and the display didn't come up. A dir(board.DISPLAY) just returned ['__class__']

When the new artifacts come up I'll try again with the non-w version (and a feather-dvi just to be sure I know how it's supposed to work).

jepler · 2025-02-12T21:28:34Z

The code is only enabled on a few boards and it's not available at all on rp2040 at all right now. I updated the initial comment to explain this more. Do I need to clarify the docs? It lists the specific boards that are supported.

jepler · 2025-02-12T21:29:39Z

(I do like the idea that boards with defined video pins but no guaranteed i2c pull-ups could still take an "always" setting via settings.toml and I would like to support more boards .. but that's not part of this PR)

jepler · 2025-02-12T21:30:15Z

The way board.DISPLAY is available everywhere also means that with this PR you should be able to configure a display in boot.py and use it in code.py as board.DISPLAY.

RetiredWizard · 2025-02-12T21:36:20Z

Sorry, no, I just jumped the gun before looking close enough. Checking for the existence of board.DISPLAY was a way of determining whether a builtin display was available, but I guess I can check the type now as board.DISPLAY is a Nonetype on boards that the new code is not enabled on.

An interesting observation though is that if you create a picodvi instance to bring up a display on a board not supported the board.DISPLAY object type changes to FramebufferDisplay. That's a pretty cool feature 😁
edit just saw the post you made while I was typing this...

jepler · 2025-02-12T21:39:58Z

I appreciate the comments, it's a chance to figure out if there's more to say in documenting this.

Yes, it's true that hasattr(board, "DISPLAY") will now return True on boards with no factory-configured display, as long as they have displayio enabled. I see that this is checked at least two places in our libraries and I'm going to file a few bugs about it.

libraries/helpers/bitmapsaver/adafruit_bitmapsaver.py:        if not hasattr(board, "DISPLAY"):
libraries/helpers/displayio_layout/adafruit_displayio_layout/layouts/tab_layout.py:            if hasattr(board, "DISPLAY"):

jepler · 2025-02-12T21:40:32Z

if not getattr(board, 'DISPLAY', None): ... will work across versions of circuitpython, I think

RetiredWizard · 2025-02-12T21:45:34Z

Your opening comment is clear enough regarding the supported boards, I just got excited when I saw all the DISPLAY entries being dropped from pins.c on other boards, I thought there may have been a scope change. I should have looked closer and realized that none of the board.c files were updated so any existing display initializations would still be in effect.

Historically, boards with no built-in display have not had a `board.DISPLAY` property. Soon, with adafruit/circuitpython#10028, any board with displayio will have a `board.DISPLAY` property. This property will be `None` if no display is configured, or a truthy non-`None` value if a display is configured (including dynamically at runtime). This revised check will work on both old and new circuitpython versions.

jepler · 2025-02-12T21:50:09Z

The schematic shows pull ups are present on the pico dv base so it would be a candidate for enabling the auto-dvi code.

tannewt · 2025-02-13T16:52:05Z

@jepler I don't think board.DISPLAY should exist on everything because it is on "board". board should only have board specific things in it. I think it is valid to check hasattr.

Instead I'd like to move to supervisor.runtime.display: #8675

tannewt

One small thing plus changing board.DISPLAY presence on some boards.

docs/environment.rst

instead of board.DISPLAY

tannewt

A couple small things. Otherwise this looks right! Thank you.

tannewt · 2025-02-13T19:29:21Z

shared-bindings/supervisor/Runtime.c

@@ -204,6 +207,39 @@ MP_PROPERTY_GETSET(supervisor_runtime_rgb_status_brightness_obj,
    (mp_obj_t)&supervisor_runtime_get_rgb_status_brightness_obj,
    (mp_obj_t)&supervisor_runtime_set_rgb_status_brightness_obj);

+#if CIRCUITPY_DISPLAYIO
+//|     display: Any
+//|     """The primary configured displayio display, if any. Read-only.


Suggested change

//| """The primary configured displayio display, if any. Read-only.

//| """The primary configured displayio display, if any.

yes, good catch.

tannewt · 2025-02-13T19:32:30Z

shared-module/displayio/__init__.c

    for (uint8_t i = 0; i < CIRCUITPY_DISPLAY_LIMIT; i++) {
+        if (i == primary_display_number) {


I think this is what you want.

Suggested change

if (i == primary_display_number) {

if (keep_primary && i == primary_display_number) {

That's originally what I had, but I changed it. Here's my logic: If !keep_primary, then primary_display_number was updated just above and will always be -1 here. -1 will never be equal to the loop counter.

jepler · 2025-02-13T21:10:02Z

Closing in favor of rebased version

jepler requested a review from tannewt February 4, 2025 20:39

tannewt requested changes Feb 5, 2025

View reviewed changes

ports/raspberrypi/boards/adafruit_feather_rp2350/board.c Outdated Show resolved Hide resolved

ports/raspberrypi/common-hal/picodvi/__init__.c Outdated Show resolved Hide resolved

ports/raspberrypi/boards/adafruit_feather_rp2350/board.c Show resolved Hide resolved

jepler mentioned this pull request Feb 6, 2025

rp2350: dvi display blanks during flash writes #10031

Closed

jepler added 12 commits February 11, 2025 15:15

Use module attribute delegation to make board.DISPLAY always work

4c61d61

Let's see if this works out in terms of code space.

Move MaTouch link to the right spot

890c7f2

Document RP2350 DVI display configuration

9cbfc41

Add preflight function for picodvi display

7e373ad

There's only an implementation for RP2350 right now, as it's not used/needed on RP2040.

picodvi_autoconstruct: preflight settings, use width=0 to disable

8675097

board: fix build errors

22f25c5

metro rp2350: configure display pins & autoconstruct

551b981

remove this, it got moved to common code

8be1681

eliminate a bit more code if the DVI/hstx pins aren't defined

61ea718

fix the DISPLAYIO_ITEMS they were backwards

3a84599

Add an environment variable to disable or force picodvi

e820416

and auto-set height and support rotation similar to how it's done on some of those dot clock display espressif boards

Merge remote-tracking branch 'origin/main' into feather-rp2350-autodvi

1d9b83f

jepler marked this pull request as ready for review February 12, 2025 20:20

jepler requested a review from tannewt February 12, 2025 20:20

tannewt requested changes Feb 12, 2025

View reviewed changes

docs/environment.rst Outdated Show resolved Hide resolved

ports/espressif/boards/m5stack_m5paper/pins.c Outdated Show resolved Hide resolved

ports/raspberrypi/common-hal/picodvi/__init__.c Outdated Show resolved Hide resolved

jepler added 4 commits February 12, 2025 14:54

Remove a comment that refers to previously deleted code

201bc69

picodvi: Fall back to the default mode if preflight fails

f0e3130

circuitpy_mpconfig: fix build config

0846aa4

.. some boards need MODULE_ATTR_DELEGATION for other reasons than displayio.

fix WIDTH unintentionally changed to HEIGHT

025f4fd

jepler changed the title ~~Auto-configure display on Feather RP2350~~ Auto-configure display on some RP2350 boards Feb 12, 2025

jepler mentioned this pull request Feb 12, 2025

Update how board.DISPLAY is checked adafruit/Adafruit_CircuitPython_BitmapSaver#37

Merged

jepler mentioned this pull request Feb 12, 2025

Update how board.DISPLAY is checked adafruit/Adafruit_CircuitPython_DisplayIO_Layout#96

Closed

jepler requested a review from tannewt February 12, 2025 23:10

tannewt requested changes Feb 13, 2025

View reviewed changes

docs/environment.rst Outdated Show resolved Hide resolved

jepler added 3 commits February 13, 2025 11:14

spell out environment variable names in full

4aeddf2

Move the new display accessor to supervisor.runtime.display

86fe684

instead of board.DISPLAY

Make primary display settable, defaults to None unless set by board_init

83415e7

tannewt requested changes Feb 13, 2025

View reviewed changes

jepler mentioned this pull request Feb 13, 2025

Add supervisor.runtime.display & RP2350 DVI autoconfig (rebased version) #10062

Merged

jepler closed this Feb 13, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-configure display on some RP2350 boards #10028

Auto-configure display on some RP2350 boards #10028

jepler commented Feb 4, 2025 •

edited

Loading

jepler commented Feb 4, 2025

tannewt left a comment

tannewt commented Feb 10, 2025

tannewt left a comment

RetiredWizard commented Feb 12, 2025

jepler commented Feb 12, 2025

jepler commented Feb 12, 2025

jepler commented Feb 12, 2025

RetiredWizard commented Feb 12, 2025 •

edited

Loading

jepler commented Feb 12, 2025

jepler commented Feb 12, 2025

RetiredWizard commented Feb 12, 2025

jepler commented Feb 12, 2025

tannewt commented Feb 13, 2025

tannewt left a comment

tannewt left a comment

tannewt Feb 13, 2025

jepler Feb 13, 2025

tannewt Feb 13, 2025

jepler Feb 13, 2025

jepler commented Feb 13, 2025

	//\| """The primary configured displayio display, if any. Read-only.
	//\| """The primary configured displayio display, if any.

		for (uint8_t i = 0; i < CIRCUITPY_DISPLAY_LIMIT; i++) {
		if (i == primary_display_number) {

	if (i == primary_display_number) {
	if (keep_primary && i == primary_display_number) {

Auto-configure display on some RP2350 boards #10028

Auto-configure display on some RP2350 boards #10028

Conversation

jepler commented Feb 4, 2025 • edited Loading

jepler commented Feb 4, 2025

tannewt left a comment

Choose a reason for hiding this comment

tannewt commented Feb 10, 2025

tannewt left a comment

Choose a reason for hiding this comment

RetiredWizard commented Feb 12, 2025

jepler commented Feb 12, 2025

jepler commented Feb 12, 2025

jepler commented Feb 12, 2025

RetiredWizard commented Feb 12, 2025 • edited Loading

jepler commented Feb 12, 2025

jepler commented Feb 12, 2025

RetiredWizard commented Feb 12, 2025

jepler commented Feb 12, 2025

tannewt commented Feb 13, 2025

tannewt left a comment

Choose a reason for hiding this comment

tannewt left a comment

Choose a reason for hiding this comment

tannewt Feb 13, 2025

Choose a reason for hiding this comment

jepler Feb 13, 2025

Choose a reason for hiding this comment

tannewt Feb 13, 2025

Choose a reason for hiding this comment

jepler Feb 13, 2025

Choose a reason for hiding this comment

jepler commented Feb 13, 2025

jepler commented Feb 4, 2025 •

edited

Loading

RetiredWizard commented Feb 12, 2025 •

edited

Loading