-
Notifications
You must be signed in to change notification settings - Fork 698
Update to Ruby 3 and add RPI CP boards #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run the Jekyll build on pull_request as well to make sure it works
makermelissa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for updating the URLs.
|
FYI, looks like the build action is failing. |
|
Possibly a permission issue, as pull requests are from forks and not a trusted source. build.yml uses github secrets. More info here on how to fix it: Example Brent did yesterday: |
|
deploy should be guarded by an if: condition, then? |
|
I think the build step is doing fancier things than just building the site like fetching and committing new files. Could we split the data update from the build so that 1) we don't build on a schedule and 2) everyone can build on their branch. |
I'm wrong about this. The build step was fine. I'll add a condition on the deploy. |
|
Build is green @makermelissa. I had to prevent the deploy when running on a PR. |
makermelissa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, that works for me.
|
Not sure if you're waiting on Justin to also review. |
Run the Jekyll build on pull_request as well to make sure it works