Add Orange Pi Boards (One, Lite, Plus 2E) #383
Conversation
|
Hey! how can I add notes on the page? Is there any format to follow? Is just to mention that the pinout on Orange Pi One and Lite the pins are shifted 180 degrees. |
|
You could probably just put it in the description section, but what do you mean that they're shifted 180 degrees? According to pics and pinout diagrams I could find, it appears they are the same direction. |
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Hi, there should be 3 images for each board and they should be in 10:13 aspect ration to look their best. You can check out a guide I wrote on doing this here:
https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/preparing-the-images.
|
Hey @makermelissa! That's what I thought at first but as for https://linux-sunxi.org/Xunlong_Orange_Pi_One_%26_Lite if you head over the expansion port it states that shifting 180 degrees. I can add the same info as in sunxi in the description as you suggested. Regards. |
|
Regarding the images, I commented when opening the PR that I'll add them I just didn't get the time to edit them :( sorry for that. I'll do it tomorrow for sure. I did add the original ones and it just missing the small and large right? Or you ment that even the original are wrong? |
|
Oh, gotcha. I missed that. If the small and large are present, the original dimensions don't really matter. It's supposed to be a fallback image, but using one large image that's loaded can slow things down. |
|
No problem, I'll do it tomorrow for sure so all images are ok and site doesn't take long to load, thank you very much for your comments. I really appreciate you taking the time on reviewing my endless PRs hahaha. |
|
I see what you mean, they're shifted 180 degrees from the Raspberry Pi rather than from each other. It probably doesn't matter to add it to here. This is more the type of thing that would be put into a guide. |
jepler
changed the title
|
Ok, so I'll fix the images and we are ok, right? If you want me to do something regarding the guide just let me know. Also if there is anything else you want me to change in this PR just tell me. |
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Doing a little more thorough review...
Double check that your info for the boards is correct. I see a couple of descriptions referencing the name Orange Pi PC. Otherwise just update the images and it should be good.
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Could you adjust the images for the one and lite images so they are 13:10 aspect ratio. The 2e looks good. sizes I like to use (same as you used for the 2e):
Large: 780x600
Small: 293x225
Thanks
|
Of course, I'll fix it but I think the pushed images size for the large and small format are exactly those 😔 but I'll double check then. I'll also check the aspect ratio is correct as in the 2e. Thanks for doing the review. |
|
Hey @makermelissa, I have done the changes as you requested, sorry for the delay on it. |
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Thanks! Looks much better.
|
hi these commits seem to be malformed?
|
|
I'll check them out and submit a pr. |
|
Ups, my bad. Reference a Sorry for the inconveniences. |
3 participants
This solve issue #376
Still missing small and large images for Orange Pi One and Lite, I'll be adding them tomorrow or Monday.