Ohs2020 badge page #377
Merged
Ohs2020 badge page #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2020 16:23
Signed-off-by: Michael Welling <mwelling@ieee.org>
3D render for now
Contributor
Author
|
Per request on adafruit/circuitpython#2528 |
Contributor
Author
|
Sorry for taking so long I had to create the 3D renders because I don't have any board. |
makermelissa
requested changes
Jan 17, 2020
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Hi, thanks for submitting. Could you pare the features down to what's in the list on this page? https://learn.adafruit.com/how-to-add-a-new-board-to-the-circuitpython-org-website/adding-to-downloads
Thanks
added 2 commits
January 16, 2020 16:42
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Michael Welling <mwelling@ieee.org>
Contributor
Author
|
@makermelissa Is that better? |
Collaborator
|
Yes, thank you. I have one other small change is to request so that the images look their best on the site. Would you be able to resize the large and small images to 780x600 and 293x225? If not, I could do it in a separate PR. Thanks. |
Contributor
Author
|
Sure lemme take a look. |
added 2 commits
January 16, 2020 16:56
Contributor
Author
|
Better? |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add page and images for the OHS2020 badge.