Clean up styles on download page #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
approved these changes
Mar 12, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good to me! Thank you for fixing the positioning!
tylerdcooper
approved these changes
Mar 13, 2019
|
On Wednesday, March 13, 2019, 11:35:41 AM EDT, Justin Cooper <notifications@github.com> wrote:
Merged #23 into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
thank you
On Wednesday, March 13, 2019, 12:20:29 PM EDT, Sue <weebles_over@yahoo.com> wrote:
On Wednesday, March 13, 2019, 11:35:41 AM EDT, Justin Cooper <notifications@github.com> wrote:
Merged #23 into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one change that differs from the mockup is that I updated the width of the select, as it looked better with some of the longer languages. I can revert it, but it was easy to get it to align well with the grid for all responsive sizes as well with this style.