-
Notifications
You must be signed in to change notification settings - Fork 698
Libraries and Contributing page #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kattni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've submitted a few changes to the html pages.
|
The last change needed based on feedback is the |
kattni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing! Thank you for incorporating my updates! We're super close. We need to get the number of PRs added to the json file, and there are a couple of checks on the Library Infrastructure Issues list that need to be removed (sommersoft is on this).
I have one thing I meant to mention last time and failed to. See below.
|
@kattni, @sommersoft this is ready to go, if we're ready to merge the script. I think we could merge the script to master first, and then merge this in after. |
kattni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this! I really appreciate you sticking with me through it.
We can merge in whatever order you like, however the script won't do anything until we setup Travis. That's something that we will do.
|
Discussed with both @jwcooper and @sommersoft. This is ready to merge! |
Work in progress...