Continue trying to fix RSS feed absolute URLs #1383
Conversation
Originally, both the RSS feed and the board list pages used the same board_image.html include; I added `| absolute_url` to this file for the RSS feed, which functions better when all links are absolute. Using `| absolute_url` is preferable to just prepending `https://circuitpython.org` because it can give a correct URL when previewing locally with `bundle run jekyll serve`. This crossed with a change by @makermelissa to switch the feeds to use a separate include, presumably (though I didn't specifically ask her about it) to avoid having the absoulute URLs where they were not needed. In this commit, I remove the use of `absolute_url` in the include that's used to generate regular pages, while switching from prepending `https://circuitpython.org` to using `| absolute_url` on the include that is used just for the feed.
|
Tested locally, the download list page images work and are relative; the rss feed links are absolute links to localhost:4000. |
|
Do you know if the absolute_url works for loading images locally? If so, you could probably just combine the 2 pieces of code. |
|
Yes, unless I'm failing to understand something or my testing is insufficient, the "feed_board_image.html" from this issue include would work equally well for the board list pages from the point of view of a user. In 'view source' you would see a redundant specification of the full URL of the images ( If you want me to re-do this PR so that it re-combines the two include files I'm happy to do that. My assumption had been that since you split them out subsequent to my two PRs adding |
Please do. I was just in a hurry as I was at the end of my day and it was the simplest way to make the change that I knew would work for certain. |
After discussion, having an absolute URL in the generated HTML is just fine.
|
Updated. |
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks good. Thanks.
2 participants
Originally, both the RSS feed and the board list pages used the same board_image.html include; I added
| absolute_urlto this file for the RSS feed, which functions better when all links are absolute.Using
| absolute_urlis preferable to just prependinghttps://circuitpython.orgbecause it can give a correct URL when previewing locally withbundle run jekyll serve.This crossed with a change by @makermelissa to switch the feeds to use a separate include, presumably (though I didn't specifically ask her about it) to avoid having the absoulute URLs where they were not needed.
In this commit, I remove the use of
absolute_urlin the include that's used to generate regular pages, while switching from prependinghttps://circuitpython.orgto using| absolute_urlon the include that is used just for the feed.