Skip to content

Conversation

@dglaude
Copy link
Contributor

@dglaude dglaude commented Aug 23, 2022

This beetle-esp32-c3 board has a connector so that you can attach a display sold separatly.
Do we consider that a display?

From the documentation:

  • "Besides, the onboard easy-to-connect GDI saves the trouble of wiring when using a screen."
  • "Comes with expansion board, more convenient to make projects or use with a screen"

This board has a connector so that you can attach a display sold separatly.
Do we consider that a display?

From the documentation:
* "Besides, the onboard easy-to-connect GDI saves the trouble of wiring when using a screen."
* "Comes with expansion board, more convenient to make projects or use with a screen"
@dglaude
Copy link
Contributor Author

dglaude commented Aug 29, 2022

Will have to find a proper name for the Feature: "Made for a Display".
Native English speaker might help here...this will apply to this board with a GDI connect and the two HUB75 discussed in #1032
I don't know yet how to add a new feature (or I forgot) so once I figure that I will put all the change in this one PR.

@dglaude dglaude changed the title beetle-esp32-c3 not a "display" but a "connector". Boards without a "Display" but with a "connector" for one. Aug 29, 2022
@makermelissa
Copy link
Collaborator

"Intended for External Display" perhaps

@makermelissa
Copy link
Collaborator

It will need to be changed on all boards as well as the template. It's kind of tedious at the moment.

@deshipu
Copy link
Contributor

deshipu commented Aug 29, 2022

Maybe "Optional Display"? Or just "External Display".

@kattni
Copy link
Contributor

kattni commented Aug 29, 2022

"Display ready"?

@dglaude
Copy link
Contributor Author

dglaude commented Aug 29, 2022

Ok, I'll start putting on the boards, currently that is only 3 boards...
For the template, I don't really know where that is.

Current options (need a voting place?):
"External Display Connector"
"Intended for External Display"
"Optional Display"
"Display Friendly"
"Display Ready"

@makermelissa
Copy link
Collaborator

I updated issue #1032 to be about the name, so that would be a better place to keep the suggestions together.

@dglaude dglaude changed the title Boards without a "Display" but with a "connector" for one. Boards without a "Display" but with a "connector" for one. (WIP) Sep 19, 2022
@dglaude
Copy link
Contributor Author

dglaude commented Sep 19, 2022

I updated issue #1032 to be about the name, so that would be a better place to keep the suggestions together.
So the result of a vote in Discord made "External Display" the winner.
I'll try to add that to the 3 boards identified, but if there are other change needed to make a new feature "real" I will need your help.

@dglaude
Copy link
Contributor Author

dglaude commented Sep 19, 2022

I think all the board that need tagging are tagged... but I don't know what else to modify.

I found the build.yml and I see where the call to check-boards.py is but I don't know what check are made and if there is something I can modify to make it pass the test:

    - name: Check feature names and other data
      run: python3 check-boards.py

@dglaude dglaude changed the title Boards without a "Display" but with a "connector" for one. (WIP) Boards without a "Display" but with a "connector" for one. Sep 19, 2022
@makermelissa
Copy link
Collaborator

It will need to be updated in https://github.com/adafruit/circuitpython-org/blob/main/template.md as well. That's what the comparison is being made to for regular boards. For blinka boards, I just have values in the checks file until I think of something better.

Let's see if by putting "External Display" here it will pass the test.
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa makermelissa merged commit 4b644b4 into adafruit:main Sep 20, 2022
@dglaude dglaude deleted the patch-4 branch September 24, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants