Skip to content

Conversation

@dglaude
Copy link
Contributor

@dglaude dglaude commented Aug 23, 2022

Should we consider a 7x17 LED matrix to be a display?
I believe only LCD or OLED display should be tagged as having a display.
However I added the Alligator Clip friendly as it looks like a Micro:bit.

Should we consider a 7x17 LED matrix to be a display?
I believe only LCD or OLED display should be tagged as having a display.
However I added the Alligator Clip friendly as it looks like a Micro:bit.
@dhalbert
Copy link
Collaborator

I think @deshipu would say that LED matrices are displays. They are low-resolution, but they can be used for gaming and scrolling text display.

@dglaude
Copy link
Contributor Author

dglaude commented Aug 23, 2022

One could say that the 5x5 from Micro:bit is a display... so it is hard to put a limit. My idea was that OLED or LCDs are screen, and a bunch of LEDs is not.

I did see the pewpew from @deshipu and I did not react the same way as for Pico:ed or the two mixgo_ce_* so I am obviously biased, maybe the joystic presence made it clear to me that this was a "screen".

Maybe for display it is not such a big deal, if it is visible in the picture, and not the kind of display the user expect, it will be discarded. For other feature, if a board pretending to have Wifi, but wifi that is not supported by CircuitPython... then I would prefer to have that feature not tagged for that board (and it is the case for the only offender I know off, the Wio Terminal).

If we decide this board has a screen, then I still need to add the "Solder-Free Alligator Clip" but it can be another PR.

@makermelissa
Copy link
Collaborator

One could say that the 5x5 from Micro:bit is a display... so it is hard to put a limit. My idea was that OLED or LCDs are screen, and a bunch of LEDs is not.

Generally that's true. We should probably add the display feature to the micro:bit as well. A lot of the example code uses that as one, albeit an extremely low resolution display. Because one of our goals was to keep the feature list to a minimum, I think we should err on the side of calling a bunch of LEDs arranged in a matrix a display rather than create a new category.

The way I think about it is if somebody is filtering for boards with displays for some project and they saw a few with LEDs would they be okay with having that as an option?

@dglaude
Copy link
Contributor Author

dglaude commented Aug 23, 2022

The way I think about it is if somebody is filtering for boards with displays for some project and they saw a few with LEDs would they be okay with having that as an option?

Feel free to discard/close the PR not matching that or maybe let's put the question as "In the Weed" and wait for a decision there.

@makermelissa
Copy link
Collaborator

I'd like to think about this some more before closing or merging.

By discussion on the 20220829 meeting, this is also a display... however I keep the PR for the Aligator Clip
@dglaude dglaude changed the title ELECFREAKS Pico:ed no display but Alligator Clip ELECFREAKS Pico:ed have a display but also Alligator Clip Aug 29, 2022
@makermelissa
Copy link
Collaborator

For the terms, let's go with:
Built-in Display
External Display Connector

"External Display Connector "could be added to the bare metal Raspberry Pi SBCs and similar boards as well.

@dglaude
Copy link
Contributor Author

dglaude commented Aug 29, 2022

Keeping the PR open for the Aligator Clip feature that was missing, but not removing the Display as discussion on 20220829 decided those LED matrix are small display.

@makermelissa
Copy link
Collaborator

I'll create a new issue for the Display name thing.

@makermelissa
Copy link
Collaborator

Actually, I'll use #1032.

@dglaude
Copy link
Contributor Author

dglaude commented Sep 19, 2022

@makermelissa If you could review this change, that "ELECFREAKS Pico:ed" has a "Display" but is missing Alligator Clip feature until merged.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, looks good.

@makermelissa makermelissa merged commit 56386c0 into adafruit:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants