This repository was archived by the owner on Sep 30, 2019. It is now read-only.
SPI: Make sure CS line is active-low #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If another user configures the SPI bus as CS active-high, the setting will stick. It is thus possible to end up in a situation where CS is forced high during SPI transactions. The solution is to explicitly disable 'cshigh' before using the SpiDev object.
|
Thanks for sending the change! I'll merge it in as it's low risk and might resolve an odd scenario like you mention of multiple devices sharing the SPI bus and leaving it in an odd state. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If another user configures the SPI bus as CS active-high, the setting will stick. Thus, it is possible to end up in a situation where where CS is forced high during SPI transactions. The solution is to explicitly disable cshigh before using the SpiDev object.