Pylint and RTD update patch, and other fixes #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Nov 10, 2021
| - id: pylint_examples | ||
| name: pylint (examples code) | ||
| args: | ||
| - --disable=consider-using-f-string |
There was a problem hiding this comment.
If the PR fails on duplicate code, please update this line to the following.
Suggested change
| - --disable=consider-using-f-string | |
| - --disable=consider-using-f-string,duplicate-code |
There was a problem hiding this comment.
Oh I missed that, good catch!
Will disable duplicate code if this causes the CI to fail
|
Didn't need to disable duplicate code |
kattni
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.