added typing for image, scs, and, reverse_bit num #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
requested changes
Apr 25, 2023
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Thanks for working on this!
I have a few changes in mind that I think would be good to make.
Closed
2 tasks
FoamyGuy
approved these changes
Apr 28, 2023
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Latest version looks good to me. Thanks again for working on this @SebastienFauque!
I added one commit to put in the "unused" typing import which we need for when the library runs on microcontrollers.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 28, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_MONSTERM4SK to 0.3.14 from 0.3.13: > Merge pull request adafruit/Adafruit_CircuitPython_MONSTERM4SK#15 from SebastienFauque/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_OV to 1.0.11 from 1.0.10: > Merge pull request adafruit/Adafruit_CircuitPython_OV#17 from patenaud/type_annotations > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.4.7 from 1.4.6: > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#23 from SebastienFauque/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_hashlib to 1.4.11 from 1.4.10: > Merge pull request adafruit/Adafruit_CircuitPython_hashlib#22 from ChrisPappalardo/add-missing-type-annotations > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typing for the SharpMemoryDisplay. Should close issue: #17