resolves #13 Missing Type Annotations #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
Contributor
Author
|
the most recent commit was to do the kwargs |
tekktrik
requested changes
Aug 25, 2022
tekktrik
approved these changes
Aug 27, 2022
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Thanks for another good typing PR!
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 27, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_GUVX_I2C to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_GUVX_I2C#3 from sokratisvas/add-type-annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.20 from 3.4.19: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#34 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.10 from 1.3.9: > Merge pull request adafruit/Adafruit_CircuitPython_INA260#20 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.2.9 from 2.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#32 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.3.9 from 1.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#16 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.15 from 1.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#13 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.12 from 1.0.11: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#8 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.3 from 1.14.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#80 from tekktrik/bugfix/multiple-networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submitted for review/comment:
I went a little further here and added the kwargs to the docstring. Also, if rotation is triggered the action is raising questions in my mind compared to the spi devices I did prior:
This is just setting height = width. Shouldn't it also set width = height to make a complete rotation of 90 deg?