Fix chunked request detection #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The response to http://site.api.espn.com/apis/site/v2/sports/basketball/mens-college-basketball/scoreboard has an extra space between Transfer-Encoding: and chunked so the comparison fails. Fixes adafruit#64
Member
Author
|
@jedgarpark This should fix your demo. You can try this version of adafruit_requests.py to see. |
makermelissa
approved these changes
Jan 28, 2021
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Other than the 2 spaces in Transfer-Encoding: chunked, which is more of a nitpick since it's just a test, it looks good to me. I didn't test.
|
It works! Thanks @tannewt |
Member
Author
I'm not sure what you mean by this. The test is exactly for the 2 spaces. That's what the ESPN server is giving us and is being fixed. |
Collaborator
|
Oh, then no worries. :) |
Collaborator
|
Also, I was helping John and have tested now. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 29, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.4 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#65 from tannewt/better_chunked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response to http://site.api.espn.com/apis/site/v2/sports/basketball/mens-college-basketball/scoreboard
has an extra space between Transfer-Encoding: and chunked so the
comparison fails.
Fixes #64