Adding GC9A01A #129
Merged
Adding GC9A01A #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
reviewed
Feb 10, 2025
adafruit_rgb_display/gc9a01a.py
Outdated
|
|
||
| super().init() | ||
|
|
||
| self._block(0, 0, self.width - 1, self.height - 1) |
There was a problem hiding this comment.
@BlitzCityDIY What does this call to self._block() here do? If you're still set up to test on RPi can you check if everything still works if this is commented out or removed?
I tested under CircuitPython with a QTPY esp32-S2 and found that this statement blocks execution during the display initializer, so the given example code never gets past the line
display = gc9a01a.GC9A01A(spi,cs=digitalio.DigitalInOut(tft_cs),dc=digitalio.DigitalInOut(tft_dc))
If I comment this call to self._block() out then the display initializes and drawing on it seems to work as expected from circuitpython
There was a problem hiding this comment.
tested and _block wasn't doing anything so just removed that
FoamyGuy
approved these changes
Feb 10, 2025
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 11, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_OV5640 to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_OV5640#35 from jerryneedell/jerryn_buffer Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.13 from 3.12.7: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#129 from adafruit/gc9a01a Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.11.5 from 7.11.4: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#238 from dhalbert/test_recv_timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GC9A01A driver. Tested with Raspberry Pi and EYESPI beret