relinted to match cookiecutter #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@tannewt Is this better? I remove the docs directory here too. added conf.py, requirements.txt, readthedocs.yml and api.rst. reworked the comments in all the functional code. Updated README.rst. Removed setup.py |
tannewt
requested changes
Jan 26, 2018
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Yeah, this is definitely better. Thank you! One change and then it should be good to go.
|
|
||
| :target: https://circuitpython.readthedocs.io/projects/rgb_display/en/latest/ | ||
|
|
||
| :alt: Documentation Status |
Member
There was a problem hiding this comment.
I think these extra lines make it invalid. The image, target and alt lines should be next to one another.
Collaborator
Author
There was a problem hiding this comment.
ok. it think that the version of the cookie-cutter added the extra lines
Member
There was a problem hiding this comment.
Yeah, I think there is a bug with it.
tannewt
approved these changes
Jan 26, 2018
Collaborator
Author
|
@tannewt i will create a release for this. |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 27, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.0.1 from 3.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#12 from mrmcwethy/relint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6 Needed more work