Fix Pillow resampling change in rgb_display_pillow_animated_gif.py #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
requested changes
Apr 19, 2022
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Looks like a syntax error.
examples/rgb_display_pillow_image.py
Outdated
| scaled_width = width | ||
| scaled_height = image.height * width // image.width | ||
| image = image.resize((scaled_width, scaled_height), Image.BICUBIC) | ||
| image = image.resize((scaled_width, scaled_height), Image..Resampling.BICUBIC) |
Collaborator
There was a problem hiding this comment.
Looks like you have 2 periods in a row on this line
Contributor
Author
|
You are right, I was rushing. Sorry. This should be corrected now. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 23, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.13 from 3.10.12: > Patch: Replaced discord badge image > Update .gitignore > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#106 from nerdcorenet/example_animgif_resampling > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#104 from nerdcorenet/example_animgif_path > Update Black to latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pillow has deprecated use of "Image.NEAREST" for resampling method
https://github.com/python-pillow/Pillow/blob/main/docs/deprecations.rst#constants
This fixes the resampling call in rgb_display_pillow_animated_gif.py