Skip to content

Lazily parse secrets data #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekktrik merged 1 commit into from
Aug 26, 2022
Merged

Lazily parse secrets data #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions adafruit_portalbase/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,21 +102,7 @@ def __init__(
self._secrets = secrets_data
else:
self._secrets = secrets

if "networks" in self._secrets:
if isinstance(self._secrets["networks"], (list, tuple)):
self._secrets_network = self._secrets["networks"]
else:
raise TypeError(
"'networks' must be a list/tuple of dicts of 'ssid' and 'password'"
)
else:
self._secrets_network = [
{
"ssid": self._secrets["ssid"],
"password": self._secrets["password"],
}
]
self._secrets_network = None

self.requests = None

Expand Down Expand Up @@ -341,6 +327,23 @@ def connect(self, max_attempts=10):
failing or use None to disable. Defaults to 10.

"""

if not self._secrets_network:
if "networks" in self._secrets:
if isinstance(self._secrets["networks"], (list, tuple)):
self._secrets_network = self._secrets["networks"]
else:
raise TypeError(
"'networks' must be a list/tuple of dicts of 'ssid' and 'password'"
)
else:
self._secrets_network = [
{
"ssid": self._secrets["ssid"],
"password": self._secrets["password"],
}
]

for secret_entry in self._secrets_network:

self._wifi.neo_status(STATUS_CONNECTING)
Expand Down