fix resolution register width #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 4, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_INA228 to 2.0.3 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_INA228#6 from BertanT/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.30 from 3.3.29: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#42 from samblenny/fix-resolution-setter Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 4.1.15 from 4.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#217 from FoamyGuy/localize_more_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the register width fix for the resolution setter as proposed by @dhalbert at:
I've tested this by copying
adafruit_mcp9808.pytoCIRCUITPY/lib/in place ofadafruit_mcp9808.mpy. When I did that, the following code ran without giving the exception mentioned in issue #41:This is just a one character change, and I don't have pre-commit set up on this machine. So, I haven't run the pre-commit stuff.