digital_inout.py: add exceptions when ipol register is absent #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Oct 7, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please test for the attribute instead of catching an exception. That way the code is clearer and doesn't capture any other unexpected exceptions.
adafruit_mcp230xx/digital_inout.py
Outdated
Comment on lines
151
to
156
| try: | ||
| if _get_bit(self._mcp.ipol, self._pin): | ||
| return True | ||
| return False | ||
| except AttributeError: | ||
| return False |
Member
There was a problem hiding this comment.
Proactively testing for the attribute is clearer than catching the error.
Suggested change
| try: | |
| if _get_bit(self._mcp.ipol, self._pin): | |
| return True | |
| return False | |
| except AttributeError: | |
| return False | |
| if hasattr(self._mcp, "ipol") and _get_bit(self._mcp.ipol, self._pin): | |
| return True | |
| return False |
Contributor
Author
|
Thanks for having me! |
Contributor
Author
|
Do you mind rolling out a new release? |
Contributor
There is a new release now. It takes a few moments to get uploaded to pypi and the release page. It should get added to the bundle overnight tonight and be available in there after that. |
Contributor
Author
|
Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 9, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.5.15 from 2.5.14: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#60 from regicidalplutophage/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML7700 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VEML7700#31 from adafruit/anecdata-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59