Try two times to clear the reset alert bit #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. this is needed at least on CircuitPython 8.0.0-beta.6 and esp32-s3 (prototype esp32-s3 reverse tft feather) With this change >1000 successive initializations succeeded. Before this change, it did not seem that initialization ever succeeded.
dhalbert
approved these changes
Jan 4, 2023
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
Something may have changed out from under us?? I tried a re-run; didn't help. |
|
3.11 "Removed from the inspect module:
I'll figure out what's up and fix it. |
|
.. but the second failure was different, it was a 'real' pylint failure. I corrected that, let's see how the next run goes. |
|
and the other half of the failure is because I branched from an older spot, I think. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 12, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.12 from 4.1.11: > trying 1.0.0 to make sure it'll get newer > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#59 from FoamyGuy/docs_theme_version > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#58 from FoamyGuy/docs_theme_version > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#57 from FoamyGuy/docs_theme_version > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#56 from FoamyGuy/docs_theme_version > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX1704x to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_MAX1704x#10 from adafruit/retry-reset-esp32s3 > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#35 from deshipu/main Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.2 from 2.6.1: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#107 from priestbh/main > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Ticks to 1.0.9 from 1.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_Ticks#9 from xgpt/patch-1 > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. this is needed at least on CircuitPython 8.0.0-beta.6 and esp32-s3 (prototype esp32-s3 reverse tft feather)
With this change >3000 successive initializations succeeded. Before this change, it did not seem that initialization ever succeeded.
A delay alone was not sufficient to fix the problem.
Since this has only been seen on the esp32-s3, it's likely that this is really one of those core I2C bugs that we love chasing so much. But the workaround is simple and shouldn't hurt anything besides taking a few more bytes of CIRCUITPY.