Fix reading strings that contain quotes or open/closed brackets #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 3, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_INA228 to 1.0.1 from 1.0.0: > Update adafruit_ina228.py Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1305 to 1.4.0 from 1.3.21: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1305#16 from mikeysklar/ssd1305-white-module-col-offset Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV320 to 1.0.0 from 51c14aa: < Update README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 2.3.0 from 2.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#70 from tannewt/cmap03 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.2.4 from 3.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#219 from FoamyGuy/use_ruff Updating https://github.com/adafruit/Adafruit_CircuitPython_JSON_Stream to 0.9.0 from 0.8.6: > Merge pull request adafruit/Adafruit_CircuitPython_JSON_Stream#9 from Neradoc/iterator-on-objects > Merge pull request adafruit/Adafruit_CircuitPython_JSON_Stream#8 from Neradoc/fix-string-in-string Updating https://github.com/adafruit/Adafruit_CircuitPython_USB_Host_Descriptors to 0.2.1 from 0.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Descriptors#4 from FoamyGuy/two_mice_example > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Descriptors#3 from FoamyGuy/find_mouse_helper Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_TLV320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing code did not properly ignore escaped quotes inside strings, which means that a string containing something like a serialized object would be potentially read wrong by switching in and out of being "in string".
next_valuealso did not ignore{and[that are inside a string, interpreting them as a "child" list or object.This would manifest by returning a
TransientObjectfrom a string, raisingKeyError, EOF or a JSON parsing error, or falling into an infinite loop.This PR ignores the special meaning of the first character after a backslash inside a string (outside a string it would not be valid json anyway), and rearranges the parsing code to switch more consistently between in-string and not in-string.