-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WiFiManager updates #216
WiFiManager updates #216
Conversation
b3a6fa9
to
fa62f34
Compare
fa62f34
to
5dfafb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I made some doc changes (phrasing and capitalization), and some minor code simplifications.
If this looks good to you, you should be able to use "Add suggestion to batch" on each of the changes, and then commit all the changes at once in a single commit, both via the GitHub web user interface.
After that, before merging, I will test one or more of the test programs on an AirLift board.
Co-authored-by: Dan Halbert <halbert@adafruit.com>
@dhalbert accepted them all and fixed another typo |
I tested EDIT: I also tested the old version of |
@dhalbert thanks for catching that. Please merge away! Will start updating other libs once this is released |
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 9.0.0 from 8.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#216 from justmobilize/wifi-manager-update Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.24.0 from 1.23.9: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#98 from Neradoc/add-filters-indexed-png Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Display_Emoji_Text
This:
ESPSPI_WiFiManager
toWiFiManager
and updates the signature to not take in secretsESPSPI_WiFiManager
that subclassesWiFiManager
and coverts the secrets to params