Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiFiManager updates #216

Merged
merged 5 commits into from
Feb 22, 2025
Merged

Conversation

justmobilize
Copy link
Collaborator

This:

  1. renames ESPSPI_WiFiManager to WiFiManager and updates the signature to not take in secrets
  2. create a new ESPSPI_WiFiManager that subclasses WiFiManager and coverts the secrets to params
  3. updates all examples to not use secrets
  4. Shows warnings when methods are passed secrets

@justmobilize justmobilize marked this pull request as ready for review February 19, 2025 22:22
@justmobilize justmobilize marked this pull request as draft February 19, 2025 22:22
@justmobilize justmobilize marked this pull request as ready for review February 19, 2025 22:27
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I made some doc changes (phrasing and capitalization), and some minor code simplifications.

If this looks good to you, you should be able to use "Add suggestion to batch" on each of the changes, and then commit all the changes at once in a single commit, both via the GitHub web user interface.

After that, before merging, I will test one or more of the test programs on an AirLift board.

justmobilize and others added 2 commits February 21, 2025 13:34
Co-authored-by: Dan Halbert <halbert@adafruit.com>
@justmobilize
Copy link
Collaborator Author

@dhalbert accepted them all and fixed another typo

@dhalbert
Copy link
Contributor

dhalbert commented Feb 22, 2025

@justmobilize

I tested esp32spi_simpletest.py and esp32spi_locatime.py. The first worked, the second had a keyword arg error. Turns out there were a few new keyword status_light= args in the examples, but they were meant to be status_pixel. I pushed a commit that changed all mentions status_light to status_pixel, to be more consistent, to avoid status_pixel=status_light args. Is this OK by you? If that's fine, I'll approve and merge.

EDIT: I also tested the old version of esp32spi_localtime.py, which printed the expected warning, and then continued on and fetched the time.

@justmobilize
Copy link
Collaborator Author

@dhalbert thanks for catching that. Please merge away! Will start updating other libs once this is released

@dhalbert dhalbert merged commit 4d0a107 into adafruit:main Feb 22, 2025
1 check passed
@justmobilize justmobilize deleted the wifi-manager-update branch February 22, 2025 04:32
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 22, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 9.0.0 from 8.4.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#216 from justmobilize/wifi-manager-update

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.24.0 from 1.23.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#98 from Neradoc/add-filters-indexed-png

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_Display_Emoji_Text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants