chore: allow use of bitmap_label without bitmaptools #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases, bitmaptools may not even be used - such as when displayio.Bitmap supports blit. in others, the module can run without bitmaptools as it has a fallback which works even if it's slower
FoamyGuy
approved these changes
Nov 1, 2023
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you @imnotjames
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 2, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.0.3 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#196 from imnotjames/allow-missing-bitmaptools Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.3.17 from 1.3.16: > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#27 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.15.3 from 1.15.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#95 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases, bitmaptools may not even be used - such as when displayio.Bitmap supports blit. in others, the module can run without bitmaptools as it has a fallback which works even if it's slower
fixes #192
tested by ensuring the circuitplayground express - which seems to omit
bitmaptools- can still blit even if it's slow