Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bitmap_label losing direction - bug #169 #174

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix for bitmap_label losing direction - bug #169 #174

merged 1 commit into from
Sep 12, 2022

Conversation

snkYmkrct
Copy link
Contributor

Please see my comment on issue #169

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I think your findings posted in the issue are correct.

Tested the solution from PR branch successfully with:

Adafruit CircuitPython 8.0.0-beta.0 on 2022-08-18; Adafruit PyPortal with samd51j20
Board ID:pyportal

In case it may be helpful in the future, here is the test code I used to verify the issue and fix:

import time
import board
import terminalio
from adafruit_display_text import bitmap_label

text = "Hello world"
text_area = bitmap_label.Label(terminalio.FONT, text=text)
text_area.x = 10
text_area.y = 10

text_area.label_direction = "UPR"
text_area.label_direction = "UPR"  # second time we set it causes trouble

board.DISPLAY.show(text_area)

val = 0
while True:
    val += 1
    text_area.text = f"Hello World {val}"
    time.sleep(0.3)

@FoamyGuy FoamyGuy merged commit 41f06c3 into adafruit:main Sep 12, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 13, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_HCSR04 to 0.4.14 from 0.4.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_HCSR04#29 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7565 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7565#5 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735 to 1.2.8 from 1.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7735#17 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.5.14 from 1.5.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#33 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.11 from 2.22.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#174 from snkYmkrct/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.13 from 1.2.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_JWT#16 from tekktrik/dev/issue-12

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.19 from 2.4.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#33 from duckythescientist/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants