Skip to content

removed comma on line 113 in i2c_device.py #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2020
Merged

removed comma on line 113 in i2c_device.py #57

merged 1 commit into from
Jul 27, 2020

Conversation

@phil-shenk
Copy link
Contributor

@phil-shenk phil-shenk commented Jul 27, 2020

This comma was throwing a syntax error for us (python 3.5), removing this comma fixed it

dhalbert
dhalbert reviewed Jul 27, 2020
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #56. We unfortunately can't accommodate this fix given our current auto-formatting and code format vetting.

dhalbert
dhalbert approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the initial rejection. I had forgotten we are still using black --python35, which accommodates this syntax peculiarity.

@dhalbert dhalbert merged commit eb4b21e into adafruit:master Jul 27, 2020
@dhalbert dhalbert mentioned this pull request Jul 27, 2020
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 27, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@20501cf)
fe7c38a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.0.1 from 4.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#57 from phil-shenk/issue56
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#55 from jepler/remove-stop-kwarg2
@jerryneedell
Copy link

jerryneedell commented Jul 27, 2020 •
edited
Loading

Just a question -- if I run black, with out the --python35, then presumably, it will insert the comma, correct?
If then commit the PR, will it fail in CI or will --python35 accept it with the comma thus setting up a case that may fail for some users....if they use python 3.5
My point it is, I have tended to just run black without the --python35 tanking it would "do no harm" to use a higher version. Is this incorrect?

Nevermind -- I think it will fail in CI since black --python35 will say it is not properly formatted.
That is my clue to remember to usr the --python35 setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phil-shenk @jerryneedell @dhalbert