Move cap1188 to drivers folder. #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Oct 12, 2018
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
It looks like this PR is trying to add in all the submodule files as well as your change. The only thing that should be changing is .gitmodules, libraries/drivers/cap1188 and /libraries/cap1188. Please look into what's going on here. Ping me if you need help with it.
Contributor
Author
|
Not sure how that happened. Manually cleaned up. Hopefully this is OK now. |
kattni
suggested changes
Oct 12, 2018
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
You still need to add the submodule in the same way you did before, there should be something like submodule cap1188 added at <hash> included in changed files.
.gitmodules
Outdated
| path = libraries/cap1188 | ||
| [submodule "libraries/drivers/cap1188"] | ||
| path = libraries/drivers/cap1188 | ||
| url = https://github.com/adafruit/Adafruit_CircuitPython_Bundle.git |
Contributor
There was a problem hiding this comment.
I believe the URL here is incorrect.
Contributor
Author
|
This PR is just all kinds of messed up. Sending it to the dungeon. |
Contributor
|
Closed in favor of #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally put the CAP1188 driver one folder up. This PR moves it to the correct location and updates
.gitmodules.