remove hyphen from S-35710 #466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Jun 24, 2024
Contributor
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
I renamed the repo but somehow missed changing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "official" repo URL seems to be without the hyphen, however Github seems to do some automatic redirecting so both URLs work as long as the client will follow the redirect:
https://github.com/adafruit/Adafruit_CircuitPython_S-35710.git
https://github.com/adafruit/Adafruit_CircuitPython_S35710.git
I think that the hyphen being in the name here in gitmodules is making the code that generates the library infrascruture report for circuitpython.org/contributing include this library as "not in bundle" even though it is in the bundle.
I'm hoping that this change will make it so it no longer appears in that list.