Adding VCNL4020 #442
Merged
Adding VCNL4020 #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding VCNL4020 library to the bundle under drivers.
makermelissa
requested changes
Nov 1, 2023
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
I only see 1 small issue, otherwise it looks good.
.gitmodules
Outdated
| [submodule "libraries/drivers/vcnl4020"] | ||
| path = libraries/drivers/vcnl4020 | ||
| url = https://github.com/adafruit/Adafruit_CircuitPython_VCNL4020.git | ||
| [submodule "libraries/drivers/libraries/drivers/vcnl4020"] |
Collaborator
There was a problem hiding this comment.
It looks like you accidentally left a duplicate submodule.
makermelissa
approved these changes
Nov 1, 2023
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Thanks, looks good.
Collaborator
|
I can log in as adabot on RTD, but don't see any invites. Maybe they go to some mailbox? |
Contributor
Author
|
@makermelissa hrm i'm not sure unfortunately, it just shows pending on my end. @tannewt - do the RTD adabot invites go to an email mailbox? |
Contributor
|
@BlitzCityDIY @makermelissa answering re RTD mails internally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding VCNL4020 library to the bundle under drivers. If someone with access to ReadTheDocs is able to accept the adabot invite and add to CircuitPython as a subproject I'd appreciate it