adding wii classic to bundle #424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekktrik
requested changes
Apr 5, 2023
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Minor request, but otherwise looks good!
.gitmodules
Outdated
| url = https://github.com/adafruit/Adafruit_CircuitPython_ACeP7In.git | ||
| [submodule "libraries/drivers/wii_classic"] | ||
| path = libraries/drivers/wii_classic | ||
| url = git@github.com:adafruit/Adafruit_CircuitPython_Wii_Classic.git |
Member
There was a problem hiding this comment.
The other repos use the HTTPS version of the git link, I think it might be good to remain consistent with that
Contributor
Author
There was a problem hiding this comment.
ah okay! will change 🙂
tekktrik
approved these changes
Apr 5, 2023
Member
tekktrik
left a comment
tekktrik
left a comment
There was a problem hiding this comment.
Looks good to me! Cool addition!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the wii_classic library to the bundle. Allows for interfacing with wii classic controllers over I2C.