Some small pointers on library development #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davclark
force-pushed
the
library_development_doc
branch
from
e11b562 to
e5fc372
Compare
Contributor
|
For some reason the actions seems to be running against an older commit rather than the most recent one. It's failing due to end of file newline in the new rst file. But as far as I can tell that was fixed int he latest commit so I'm not really sure why it didn't pass |
dhalbert
requested changes
May 2, 2022
LIBRARY_DEVELOPMENT.rst
Outdated
| `installing mypy`_. You can then run mypy from the command line or from within your editor / IDE. | ||
|
|
||
| .. _installing mypy: https://mypy.readthedocs.io/en/stable/getting_started.html#installing-and-running-mypy | ||
|
|
Contributor
There was a problem hiding this comment.
Still a blank line here, causing pre-commit failure. The previous file had two blank lines.
dhalbert
changed the title
jepler
approved these changes
Nov 9, 2022
Contributor
jepler
left a comment
jepler
left a comment
There was a problem hiding this comment.
I updated the PR and fixed the whitespace problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just intended as a starting point, you are welcome to change or dispose of it as you please!