Skip to content

Conversation

@evaherrada
Copy link
Collaborator

No description provided.

@siddacious siddacious requested a review from sommersoft January 11, 2020 04:34
Copy link
Collaborator

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the Sphinx build step to build.yml, since the Adafruit Bundle has a RTD page. Quick reference:

    - name: Build docs
      working-directory: docs
      run: sphinx-build -E -W -b html . _build/html

Other than that, just need to remove the Community Bundle stuff noted below.

EDIT: sorry about the comment order. I remembered multi-line comment highlights after I purposefully made them in order, and then had to delete them.

@evaherrada
Copy link
Collaborator Author

@sommersoft I think I got everything. Let me know if there's something I missed

@evaherrada evaherrada requested a review from sommersoft January 12, 2020 01:29
@sommersoft sommersoft merged commit 5805887 into adafruit:master Jan 12, 2020
@sommersoft
Copy link
Collaborator

Thanks @dherrada!

@sommersoft
Copy link
Collaborator

Doh! They both do need sudo apt-get install gettext. I completely forgot about mpy-cross needing it. I'll push a PR real quick...

@siddacious
Copy link
Contributor

@sommersoft let me know if there is something I can do to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants