Skip to content

Conversation

@dastels
Copy link
Collaborator

@dastels dastels commented Jun 18, 2019

No description provided.

@kattni
Copy link
Contributor

kattni commented Jun 21, 2019

@dastels Please do a release on the library before submitting to the bundle, the build will fail otherwise. Thanks!

@kattni
Copy link
Contributor

kattni commented Jun 21, 2019

I restarted the build and it's still failing on no release, when there has apparently been a release. Not sure what's going on.

@siddacious
Copy link
Contributor

@kattni If you look at the exact failure, it's looking for a tag/release at commit f0a92 which indeed does not have a release because it's an earlier commit, likely not coincidentally when Limor merged Dave's addition of a travis.yml:
adafruit/Adafruit_CircuitPython_PYOA@f0a920d

Not sure why it's stuck looking for a release tag on that commit, but that's why it's failing

@siddacious
Copy link
Contributor

@kattni Looked a little closer and if you take a look at the diffs, you can see that the submodule was added at the above commit before a release. I think the easiest way to handle this would be to start over and add the submodule again now that there is a release

@kattni
Copy link
Contributor

kattni commented Jun 21, 2019

@siddacious Good catch. I noticed the commit hash but didn't look further into it.

@dastels Please resubmit the lib to the bundle. Thank you. We can close this once you have done so.

@kattni kattni merged commit fdfd4c9 into adafruit:master Jun 22, 2019
@ladyada
Copy link
Member

ladyada commented Jun 22, 2019

@dastels ok do you know the process for next time you submit a library or do ya need assistance?

@dastels
Copy link
Collaborator Author

dastels commented Jun 22, 2019

Yeah... don't add to the bundle until the end :) Question: will subsequent release be automatically picked up in the bundle or does the submodule need to be refreshed?

@ladyada
Copy link
Member

ladyada commented Jun 22, 2019

the submodule is auto-checked daily, just do a proper semver release to get it picked up for next day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants