Added Displayio Drivers for multiple displays #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Apr 22, 2019
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
The ili9341 submodule doesn't match a release. Adabot will rewind to the latest release as is now. Please release the version you have added as a submodule.
Thanks for doing this!
kattni
suggested changes
Apr 22, 2019
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Please resolve the merge conflict. Thanks!
Collaborator
Author
|
Ok thanks. I’ll update tonight. |
Collaborator
Author
|
Thanks for catching that @tannewt. I was wondering if that might happen with the merge conflict since there was a pending PR. Ok, I fixed the merge conflicts and released latest ili9341. |
Collaborator
Author
|
Thanks @kattni |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the following Displays:
HX8357
ILI9341
SSD1331
SSD1351
ST7735
ST7735R
ST7789