Update: Flexible setting sample rate #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Oct 2, 2025
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Thanks for working on this.
I think this is fine in order to expose the capability as a public API. Looks good to me, did not test, don't have the hardware.
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 3, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X to 1.3.0 from 1.2.10: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x#58 from RenMurakami/main Updating https://github.com/adafruit/Adafruit_CircuitPython_CST8XX to 1.1.0 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_CST8XX#1 from arturo182/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.14.2 from 3.14.1: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#134 from adafruit/tannewt-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.21 from 1.0.20: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#16 from spridget/patch-3 Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.11.0 from 1.10.4: > Merge pull request adafruit/Adafruit_CircuitPython_Register#59 from FoamyGuy/accessor_layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module does not have a way to set sample rate manually.
_DEFAULT_REPORT_INTERVAL sets fixed rate
_DEFAULT_REPORT_INTERVAL has fixed sample rate value.
Need to make _get_feature_enable_report public not private
_get_feature_enable_report set sample rate. I needs to be get_feature_enable_report, so users can set sample rate manually.
bno.enable_feature(BNO_REPORT_ACCELEROMETER, REPORT_INTERVAL)This is how to set report interval.