Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/adafruit/Adafruit_CircuitPython_BME680/issues/67 #68

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

CTho9305
Copy link
Contributor

Apply the fix suggested @antoine-sac after rechecking Bosch's example code, and allow the gas reading to be disabled entirely by calling set_gas_heater(None, None) in case somebody does not need the gas reading.

@CTho9305 CTho9305 requested a review from FoamyGuy December 8, 2023 03:53
@FoamyGuy
Copy link
Contributor

Thanks for the additional insight into the code.

I tried testing this on a very old BME680 that I have but wasn't having any luck getting it connected properly (likely not related to these changes, I think my wiring is improper). I have a newer one otw with a simpler and more widely compatible way to connect. Once I've got that in hand I'll give this a test and merge if all is well.

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this successfully on a Feather S3 TFT. With the simpletest script from this repo modified to enable and disable the heater.

I did observe the extra delay with the currently released version and confirmed this PR version does not have that extra delay any more.

Thank you for these improvements and your explanations @CTho9305!

@FoamyGuy FoamyGuy merged commit 41fca05 into adafruit:main Dec 23, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants