Make UARTService characteristics be at least as large as max MTU-3 #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
User Thinman in discord tested and it fixes their problem. |
tannewt
reviewed
Oct 18, 2024
dhalbert
force-pushed
the
nus-buffers-at-least-mtu
branch
from
19fae83 to
d1d3fea
Compare
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 22, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 10.0.9 from 10.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#203 from dhalbert/nus-buffers-at-least-mtu > Merge pull request adafruit/Adafruit_CircuitPython_BLE#206 from dhalbert/pnp_id-defaults > Merge pull request adafruit/Adafruit_CircuitPython_BLE#204 from adafruit/dhalbert-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_BLE#202 from ktnyt/device-info-pnp-id Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_USB_Host_Mass_Storage, Adafruit_CircuitPython_USB_Host_MIDI Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.
Nordic UART Service clients expect that they will be able to send MTU-3 bytes all at once, in a single write. The current code was expecting no more than 20-byte writes.
Currently the maximum MTU-3 used by all CircuitPython ports is 512-3 (which is wrong, it should be 512). Change the
max_lengthfor the characteristic to be 512, and also enlarge the PacketBuffer correspondingly.Tested with UART sends from Adafruit Bluefruit Connect app and nRF Toolbox on iOS on nRF52840 and Metro ESP32-S3. Also tested for regression with an nRF52840 uART client.