This repository was archived by the owner on Sep 30, 2019. It is now read-only.
prevent segfault caused by bitidx++ #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modifies Adafruit_DHT_Driver/Adafruit_DHT.c so that the code that increments `bitidx` without bound is protected by #ifdef DEBUG. This prevents this code from generating a segfault if readDHT is called several times (which will ultimately cause bitidx to increment beyond the end of the bits array). Resolves github issue adafruit#78.
|
Thanks for sending the pull request. I just started looking at the DHT sensors and this looks like a good quick fix to take so folks don't run into issues adapting the code to something that runs continuously. I tried the change in a modified version of the example which continually grabs a reading and sleeps for a second--no stability issues with the fix. Thanks! |
tdicola
added a commit
that referenced
this pull request
May 31, 2014
prevent segfault caused by bitidx++
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies Adafruit_DHT_Driver/Adafruit_DHT.c so that the code
that increments
bitidxwithout bound is protected by #ifdef DEBUG.This prevents this code from generating a segfault if readDHT is called several
times (which will ultimately cause bitidx to increment beyond the end of the
bits array).
Resolves github issue #78.