Skip to content
This repository was archived by the owner on Sep 30, 2019. It is now read-only.

Create LCD_Examples_4Line_Display.py #44

Closed
wants to merge 1 commit into from

Conversation

rainierez
Copy link

A demo of some of the built in helper functions of the Adafruit_CharLCDPlate.py This is 20x4 display specific for now. I'll add conditions to get it to run on 16x2, etc.

A demo of some of the built in helper functions of the Adafruit_CharLCDPlate.py This is 20x4 display specific for now. I'll add conditions to get it to run on 16x2, etc.
@tdicola
Copy link
Contributor

tdicola commented Jul 14, 2014

Thanks for submitting the pull request and apologies it wasn't reviewed sooner. I gave it a quick try with a 20x4 LCD on the char plate but ran into a couple problems. The example references an Adafruit_CharLCDPlate1 class which doesn't exist in the library. If I change it to use the normal Adafruit_CharLCDPlate class it starts to work but line breaks past 2 lines don't seem to work and it fails when it trys to call the message function (error is it's passing 2 parameters when message just takes one). It seems like there are probably some local changes to the library which might have been missed with this pull. I'll close the pull for now but feel free to grab all the changes and submit a new one. I'd suggest cloning the repo to a new directory and starting fresh to make sure git can see all the changed files. Thanks again for submitting the example!

@tdicola tdicola closed this Jul 14, 2014
@tdicola
Copy link
Contributor

tdicola commented Jul 14, 2014

Oh sorry, I just saw there's an earlier pull to add 20x4 support: #43 Let me take a look at that and see if I can integrate, then come back and integrate this example. Will reopen and merge if so, or else merge in a new pull with this example.

@tdicola
Copy link
Contributor

tdicola commented Jul 14, 2014

Made a few tweaks to the 20x4 code and merged it in with this example. Thanks for submitting the pull request!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants