Skip to content
This repository was archived by the owner on Sep 30, 2019. It is now read-only.

Update Adafruit_CharLCDPlate.py #41

Merged
merged 1 commit into from
Jul 15, 2014
Merged

Conversation

kenrbell
Copy link
Contributor

@kenrbell kenrbell commented May 3, 2013

Setting read/write on wrong bit in GPIOB.
Bit 7 from display is in bit 1 of GPIOB.
Need to set/clear correct bit in IODIRB.

Setting read/write on wrong bit in GPIOB. 
Bit 7 from display is in bit 1 of GPIOB.
Need to set/clear correct bit in IODIRB.
@wnovinger
Copy link

There appear to be syntax errors (e.g., with print statement, etc.) that prevent use with Python 3.1.x.

@tdicola
Copy link
Contributor

tdicola commented Jul 15, 2014

Thanks for submitting the pull request and apologies it wasn't reviewed sooner. I took a look at the schematic and see you're right the LCD display bit 7 wasn't right in the code. Tested out your fix and it works great with the examples. Will merge now, thanks!

tdicola added a commit that referenced this pull request Jul 15, 2014
Update Adafruit_CharLCDPlate.py
@tdicola tdicola merged commit 5d38766 into adafruit:master Jul 15, 2014
@kenrbell
Copy link
Contributor Author

I'd almost forgotten about that "Fix". When did I put that in?

K Bell

On Jul 14, 2014, at 6:56 PM, Tony DiCola wrote:

Thanks for submitting the pull request and apologies it wasn't reviewed sooner. I took a look at the schematic and see you're right the LCD display bit 7 wasn't right in the code. Tested out your fix and it works great with the examples. Will merge now, thanks!


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants