This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Fix potentially broken symlinks in CharLCDPlate. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching this and submitting the pull, apologies it wasn't reviewed sooner. Gave it a quick test and everything seems to work with the new symlinks. Will merge in now. Thanks! |
tdicola
added a commit
that referenced
this pull request
Jul 14, 2014
Fix potentially broken symlinks in CharLCDPlate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the 2 symlinks in CharLCDPlate were broken in my cloned repo because I used a different name for the main repo directory and the relative path symlinks did a double ".." before entering the target directory.