This repository was archived by the owner on Sep 30, 2019. It is now read-only.
Bug fix: signed differential sample values are ignored in ADS1015 (12 bi... #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
added a commit
that referenced
this pull request
Apr 1, 2015
Bug fix: signed differential sample values are ignored in ADS1015 (12 bi...
|
thx! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using ADS1015, ADS1x15.readADCDifferential method ignores signed inputs,
So positive samples make sense, but negative samples are returned as high values. This is especially frustrating in samples that oscillate around 0mV.
The fix is checking the most significant bit (11) and subtract the max value (0xFFF) from the signed sample if necessary, much like the 16 bit version.
Enjoy